Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BugFix] Fix eslint plugin import groups #154

Merged
merged 2 commits into from
Apr 30, 2023
Merged

🐛 [BugFix] Fix eslint plugin import groups #154

merged 2 commits into from
Apr 30, 2023

Conversation

jis-kim
Copy link
Contributor

@jis-kim jis-kim commented Apr 30, 2023

Summary

  • eslint-plugin-import setting 변경

Describe your changes

  • 'import/external-module-folders': ['../types'] 를 삭제하여 기존 external module 이 인식되지 않는 문제 수정
  • @/types/** 를 internal 로 설정해서 기존 상대경로 import 문보다 위에 정의

Issue number and link

@jis-kim jis-kim requested a review from anso33 April 30, 2023 08:12
@jis-kim jis-kim self-assigned this Apr 30, 2023
@jis-kim jis-kim added bug Something isn't working backend issue for backend labels Apr 30, 2023
@jis-kim jis-kim changed the title 🐛 [BugFix] Fix eslint plugin import groups #153 🐛 [BugFix] Fix eslint plugin import groups Apr 30, 2023
anso33
anso33 approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@anso33 anso33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
덕분에 eslint 설정에 대해 하나 더 알아갑니다~~

@jis-kim jis-kim merged commit ddf523f into main Apr 30, 2023
@jis-kim jis-kim deleted the hotfix/back/eslint-import branch April 30, 2023 08:14
@jis-kim
Copy link
Contributor Author

jis-kim commented Apr 30, 2023

링크 참고해서 개선.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anso33 anso33 anso33 approved these changes

Assignees

@jis-kim jis-kim

Labels
backend issue for backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] backend 에서 eslint import 순서가 보장되지 않는 오류
2 participants
@jis-kim @anso33