Skip to content

Commit

Permalink
Merge branch 'main' into enable-js-samples-for-debug
Browse files Browse the repository at this point in the history
  • Loading branch information
@adamraine
adamraine committed Oct 17, 2023
2 parents b7e00b5 + 4f0e0d5 commit 7a019cb
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 67 deletions.
6 changes: 3 additions & 3 deletions core/config/default-config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ const defaultConfig = {
{id: 'image-redundant-alt', weight: 1, group: 'a11y-names-labels'},
{id: 'input-button-name', weight: 10, group: 'a11y-names-labels'},
{id: 'input-image-alt', weight: 10, group: 'a11y-names-labels'},
{id: 'label-content-name-mismatch', weight: 7, group: 'a11y-names-labels'},
{id: 'label', weight: 7, group: 'a11y-names-labels'},
{id: 'link-in-text-block', weight: 7, group: 'a11y-color-contrast'},
{id: 'link-name', weight: 7, group: 'a11y-names-labels'},
Expand All @@ -562,8 +561,6 @@ const defaultConfig = {
{id: 'skip-link', weight: 3, group: 'a11y-names-labels'},
{id: 'tabindex', weight: 7, group: 'a11y-navigation'},
{id: 'table-duplicate-name', weight: 1, group: 'a11y-tables-lists'},
{id: 'table-fake-caption', weight: 7, group: 'a11y-tables-lists'},
{id: 'td-has-header', weight: 10, group: 'a11y-tables-lists'},
{id: 'td-headers-attr', weight: 7, group: 'a11y-tables-lists'},
{id: 'th-has-data-cells', weight: 7, group: 'a11y-tables-lists'},
{id: 'valid-lang', weight: 7, group: 'a11y-language'},
Expand All @@ -584,6 +581,9 @@ const defaultConfig = {
{id: 'identical-links-same-purpose', weight: 0, group: 'hidden'},
{id: 'landmark-one-main', weight: 0, group: 'hidden'},
{id: 'target-size', weight: 0, group: 'hidden'},
{id: 'label-content-name-mismatch', weight: 0, group: 'hidden'},
{id: 'table-fake-caption', weight: 0, group: 'hidden'},
{id: 'td-has-header', weight: 0, group: 'hidden'},
],
},
'best-practices': {
Expand Down
92 changes: 46 additions & 46 deletions core/test/fixtures/user-flows/reports/sample-flow-result.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4279,11 +4279,6 @@
"weight": 0,
"group": "a11y-names-labels"
},
{
"id": "label-content-name-mismatch",
"weight": 7,
"group": "a11y-names-labels"
},
{
"id": "label",
"weight": 7,
Expand Down Expand Up @@ -4344,16 +4339,6 @@
"weight": 1,
"group": "a11y-tables-lists"
},
{
"id": "table-fake-caption",
"weight": 7,
"group": "a11y-tables-lists"
},
{
"id": "td-has-header",
"weight": 10,
"group": "a11y-tables-lists"
},
{
"id": "td-headers-attr",
"weight": 0,
Expand Down Expand Up @@ -4433,6 +4418,21 @@
"id": "target-size",
"weight": 0,
"group": "hidden"
},
{
"id": "label-content-name-mismatch",
"weight": 0,
"group": "hidden"
},
{
"id": "table-fake-caption",
"weight": 0,
"group": "hidden"
},
{
"id": "td-has-header",
"weight": 0,
"group": "hidden"
}
],
"id": "accessibility",
Expand Down Expand Up @@ -15050,11 +15050,6 @@
"weight": 0,
"group": "a11y-names-labels"
},
{
"id": "label-content-name-mismatch",
"weight": 7,
"group": "a11y-names-labels"
},
{
"id": "label",
"weight": 7,
Expand Down Expand Up @@ -15115,16 +15110,6 @@
"weight": 1,
"group": "a11y-tables-lists"
},
{
"id": "table-fake-caption",
"weight": 7,
"group": "a11y-tables-lists"
},
{
"id": "td-has-header",
"weight": 10,
"group": "a11y-tables-lists"
},
{
"id": "td-headers-attr",
"weight": 0,
Expand Down Expand Up @@ -15204,6 +15189,21 @@
"id": "target-size",
"weight": 0,
"group": "hidden"
},
{
"id": "label-content-name-mismatch",
"weight": 0,
"group": "hidden"
},
{
"id": "table-fake-caption",
"weight": 0,
"group": "hidden"
},
{
"id": "td-has-header",
"weight": 0,
"group": "hidden"
}
],
"id": "accessibility",
Expand Down Expand Up @@ -21903,11 +21903,6 @@
"weight": 0,
"group": "a11y-names-labels"
},
{
"id": "label-content-name-mismatch",
"weight": 7,
"group": "a11y-names-labels"
},
{
"id": "label",
"weight": 7,
Expand Down Expand Up @@ -21968,16 +21963,6 @@
"weight": 1,
"group": "a11y-tables-lists"
},
{
"id": "table-fake-caption",
"weight": 7,
"group": "a11y-tables-lists"
},
{
"id": "td-has-header",
"weight": 10,
"group": "a11y-tables-lists"
},
{
"id": "td-headers-attr",
"weight": 0,
Expand Down Expand Up @@ -22057,10 +22042,25 @@
"id": "target-size",
"weight": 0,
"group": "hidden"
},
{
"id": "label-content-name-mismatch",
"weight": 0,
"group": "hidden"
},
{
"id": "table-fake-caption",
"weight": 0,
"group": "hidden"
},
{
"id": "td-has-header",
"weight": 0,
"group": "hidden"
}
],
"id": "accessibility",
"score": 0.96
"score": 0.95
},
"best-practices": {
"title": "Best Practices",
Expand Down
32 changes: 16 additions & 16 deletions core/test/results/sample_v2.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6375,11 +6375,6 @@
"weight": 0,
"group": "a11y-names-labels"
},
{
"id": "label-content-name-mismatch",
"weight": 7,
"group": "a11y-names-labels"
},
{
"id": "label",
"weight": 7,
Expand Down Expand Up @@ -6440,16 +6435,6 @@
"weight": 1,
"group": "a11y-tables-lists"
},
{
"id": "table-fake-caption",
"weight": 7,
"group": "a11y-tables-lists"
},
{
"id": "td-has-header",
"weight": 10,
"group": "a11y-tables-lists"
},
{
"id": "td-headers-attr",
"weight": 0,
Expand Down Expand Up @@ -6529,10 +6514,25 @@
"id": "target-size",
"weight": 0,
"group": "hidden"
},
{
"id": "label-content-name-mismatch",
"weight": 0,
"group": "hidden"
},
{
"id": "table-fake-caption",
"weight": 0,
"group": "hidden"
},
{
"id": "td-has-header",
"weight": 0,
"group": "hidden"
}
],
"id": "accessibility",
"score": 0.8
"score": 0.77
},
"best-practices": {
"title": "Best Practices",
Expand Down
2 changes: 1 addition & 1 deletion report/test/generator/report-generator-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('ReportGenerator', () => {
category,score
\\"performance\\",\\"0.28\\"
\\"accessibility\\",\\"0.8\\"
\\"accessibility\\",\\"0.77\\"
\\"best-practices\\",\\"0.18\\"
\\"seo\\",\\"0.67\\"
\\"pwa\\",\\"0.38\\"
Expand Down
2 changes: 1 addition & 1 deletion report/test/renderer/category-renderer-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ describe('CategoryRenderer', () => {
);

const gauge = categoryDOM.querySelector('.lh-fraction__content');
assert.equal(gauge.textContent.trim(), '22/27', 'fraction is included');
assert.equal(gauge.textContent.trim(), '19/24', 'fraction is included');

const score = categoryDOM.querySelector('.lh-category-header');
const title = score.querySelector('.lh-fraction__label');
Expand Down

0 comments on commit 7a019cb

Please sign in to comment.