Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: top-level warn if initialUrl and finalUrl are different #1917

Closed
ebidel opened this issue Mar 27, 2017 · 2 comments · Fixed by #10157
Closed

Report: top-level warn if initialUrl and finalUrl are different #1917

ebidel opened this issue Mar 27, 2017 · 2 comments · Fixed by #10157

Comments

@ebidel
Copy link
Contributor

ebidel commented Mar 27, 2017

We need to figure out some way of notifying the user if the finalUrl ended up on a different origin than the initialUrl. Mainly for the CLI and WPT cases where users can put in a URL. For the CRX / DT, users typically end up on the final URL before testing.

Separating this out from #715. @brendankenny said:

Sounds good. To close the loop: another issue with initial vs final URL is clearing storage, which is done per origin. If a redirect goes cross origin the cache, SW, etc are not cleared.

In the CLI this is only a problem if not using the default clean Chrome. In the extension you're usually already on the final (possibly redirected) URL, except when sites redirect you to a different origin due to mobile emulation.

@ebidel ebidel added the report label Mar 27, 2017
@brendankenny brendankenny changed the title Report: warn if initialUrl and finalUrl are different origins Report: top-level warn if initialUrl and finalUrl are different origins Mar 27, 2017
@brendankenny
Copy link
Member

HTTP -> HTTPS redirects should get this warning too (#2397)

@connorjclark
Copy link
Collaborator

I'm not sure we need to have different warnings if just the origin changes. Let's do just a generic warning if requested !== final.

@connorjclark connorjclark changed the title Report: top-level warn if initialUrl and finalUrl are different origins Report: top-level warn if initialUrl and finalUrl are different Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants