Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include initial http route on HTTPS audits #2397

Closed
evenstensberg opened this issue May 30, 2017 · 4 comments
Closed

Don't include initial http route on HTTPS audits #2397

evenstensberg opened this issue May 30, 2017 · 4 comments

Comments

@evenstensberg
Copy link
Contributor

Tested this on an Google Pixel XL. Seems like the initial HTTP route gets audited instead of us redirecting to HTTPS if possible and auditing that.
skjermbilde 2017-05-30 kl 23 44 33
skjermbilde 2017-05-30 kl 23 44 12

@patrickhulce
Copy link
Collaborator

@ev1stensberg could you be more specific? if you test an http url explicitly then failing these audits is expected even if it redirects to https, we could add a debug string similar to https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/works-offline.js#L47 for these though

@evenstensberg
Copy link
Contributor Author

I'd expect that we should try to audit the https if it's standard. If you're a pragmatic tester, you'd use a http protocol to ensure you get feedback. At least, that is how I'd think

@ebidel
Copy link
Contributor

ebidel commented May 31, 2017

+1 on the debug string like https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/works-offline.js#L47. This is one of those gotchas that you only run into when using the CLI. When using the extension/DevTools, you'll already be at the redirected URL.

@brendankenny
Copy link
Member

closing in favor of #1917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants