-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include initial http route on HTTPS audits #2397
Comments
@ev1stensberg could you be more specific? if you test an |
I'd expect that we should try to audit the https if it's standard. If you're a pragmatic tester, you'd use a http protocol to ensure you get feedback. At least, that is how I'd think |
+1 on the debug string like https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/works-offline.js#L47. This is one of those gotchas that you only run into when using the CLI. When using the extension/DevTools, you'll already be at the redirected URL. |
closing in favor of #1917 |
Tested this on an Google Pixel XL. Seems like the initial HTTP route gets audited instead of us redirecting to HTTPS if possible and auditing that.
The text was updated successfully, but these errors were encountered: