Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(config): add unit tests from legacy config #15209

Merged
merged 12 commits into from
Jun 28, 2023

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Jun 28, 2023

This PR adds a bunch of test cases I found in the legacy/config-test.js that were not present in any of our new test case files:

  • config-test.js (not legacy)
  • config-helpers-test.js
  • validation-test.js
  • filters-test.js

There are some minor missing features from the legacy config, but this PR is only going to address test coverage. The missing features should be addressed in separate PRs. For reference, the missing features are:

  • Throw if a requiredArtifacts is not in the config
  • throws for invalid use of skipAudits and onlyAudits
  • Deduplicate artifacts on id (previously done by gatherer name)

#15060

@adamraine adamraine requested a review from a team as a code owner June 28, 2023 18:48
@adamraine adamraine requested review from connorjclark and removed request for a team June 28, 2023 18:48
@adamraine
Copy link
Member Author

I'm gonna temporarily skip the legacy/config-test.js stuff to see where we are with codecov.

@adamraine
Copy link
Member Author

adamraine commented Jun 28, 2023

Codecov is being weird, but it looks like we don't lose any coverage when skipping the legacy config tests (excluding a bunch of stuff in legay/config/config.js which was expected)

I'm going to unskip the tests, and this should be landable.

Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy we won't be losing this test coverage :)

@adamraine adamraine merged commit ac3b444 into main Jun 28, 2023
31 checks passed
@adamraine adamraine deleted the legacy-config-test-parity branch June 28, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants