Skip to content

Commit

Permalink
fix: openerFrameId whenever possible (#2329)
Browse files Browse the repository at this point in the history
We should be able to track if what frame opened the new
`BrowsingContext`.
  • Loading branch information
Lightning00Blade committed Jun 18, 2024
1 parent ed151cf commit b3ab7ef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bidiMapper/modules/cdp/CdpTargetManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export class CdpTargetManager {
// https://html.spec.whatwg.org/multipage/document-sequences.html#creating-browsing-contexts
// TODO: check who to deal with non-null creator and its `creatorOrigin`.
targetInfo.url === '' ? 'about:blank' : targetInfo.url,
targetInfo.openerId,
targetInfo.openerFrameId ?? targetInfo.openerId,
this.#logger
);
}
Expand Down

0 comments on commit b3ab7ef

Please sign in to comment.