Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three listings for Accessible UK Train Timetables, traintimes.org.uk #505

Closed
grahamperrin opened this issue Jul 12, 2018 · 6 comments
Closed

Comments

@andreban
Copy link
Member

andreban commented Jul 13, 2018

This is due to traintimes using different manifest URL and start_urls for each URL on their site, which makes it tricky to uniquely identify a PWA (see #493, w3c/manifest#586 and w3c/manifest#668)

This could be something a website does intentionally, but looks like a bug in this case. We should keep the older record (the first one) and delete 5630437284642816 and 5678982740049920)

/cc @juliantoledo

@PaulKinlan
Copy link
Member

PaulKinlan commented Jul 13, 2018 via email

@PaulKinlan
Copy link
Member

PaulKinlan commented Jul 13, 2018 via email

@andreban
Copy link
Member

I considered that might be intentional, but since they actually have a PWA per route / day / departure time, I thought not.

For instance, https://traintimes.org.uk/Runcorn/Euston/09:04a/today has a different manifest and start_url than https://traintimes.org.uk/Runcorn/Euston/15:15/today, which is also different from https://traintimes.org.uk/Runcorn/Euston/09:04a/2018-07-13

We could group those apps by origin, but then 2 completely different PWAs under the same domain would count as a single app.

@fstanis
Copy link
Collaborator

fstanis commented Jul 13, 2018

2 completely different PWAs under the same domain

That sounds like it's potentially more of a niche case than two related apps under the same domain, no?

@juliantoledo
Copy link
Collaborator

Ideally, we should group them under a single entry, but it would be a bit difficult to compare them to know they are the "same" PWA with multiple entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants