Use kaniko to run builds for go 1.11 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Oct 3, 2018
runtime-builder/go-1.11.yaml
Outdated
| args: ['build', '-t', '$_OUTPUT_IMAGE', '.'] | ||
| images: | ||
| - '$_OUTPUT_IMAGE' | ||
| - name: 'gcr.io/kaniko-project/executor:v0.4.0@sha256:0bbaa4859eec9796d32ab45e6c1627562dbc7796e40450295b9604cd3f4197af' |
There was a problem hiding this comment.
Google Cloud Build (by Google Cloud Build) doesn't like the fancy tag/digest syntax.
There was a problem hiding this comment.
Fixed. I'll fix GCB too but I won't block this PR on it.
GCB doesn't like it (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kanikobuilds container images from a Dockerfile, and enables future improvements to speed up builds by using the image registry as a layer cache (GoogleContainerTools/kaniko#300)The kaniko builder image is referenced by digest to avoid potential bad kaniko releases, and the tag is included so humans reading the config know what kaniko version is used.