Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Run ops_agent_test on a few newer distros #1470

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Oct 17, 2023

Description

Looks like image_lists.gcl is pretty out of date when it comes to versions of SLES 15 SAP, and while I was at it, I fixed an old TODO about Windows.

Related issue

b/305026436, tangentially

How has this been tested?

automated tests will trigger the Windows change. The SLES was tested (and passed in an earlier draft of this PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans marked this pull request as ready for review October 19, 2023 19:07
@martijnvans martijnvans requested review from a team and ridwanmsharif and removed request for a team October 19, 2023 19:07
@avilevy18 avilevy18 self-requested a review October 19, 2023 19:11
@martijnvans martijnvans merged commit 2c82a6a into master Oct 19, 2023
30 of 47 checks passed
@martijnvans martijnvans deleted the martijnvans-new-sles-15 branch October 19, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants