Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futureproof Dockerfile for new versions of buildkit #1508

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

Subbarker
Copy link
Contributor

Description

Kokoro pins an older version of buildkit, so these changes haven't been necessary.

Experimentation with newer versions of buildkit breaks because ironically, they are trying to support OTEL. We need to unset the env vars that buildkit sets or we get errors like: java.net.MalformedURLException: unknown protocol: unix

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Subbarker Subbarker merged commit ea4c708 into master Nov 13, 2023
47 of 66 checks passed
@Subbarker Subbarker deleted the sarsfield-dockerfixes branch November 13, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants