Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Fix issue with building gpu drivers on rl8 #1545

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Testing: Fix issue with building gpu drivers on rl8 #1545

merged 4 commits into from
Dec 13, 2023

Conversation

LujieDuan
Copy link
Contributor

@LujieDuan LujieDuan commented Dec 13, 2023 •
edited
Loading

Description

The NVIDIA driver installation is failing on RL8 due to NVIDIA/open-gpu-kernel-modules#550. Update the script to install a newer version of the data center driver.

Related issue

b/316154675

How has this been tested?

NVML and DCGM tests pass on RL8 and other platforms.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@LujieDuan LujieDuan changed the title Fix issue with building gpu drivers on rl8 Testing: Fix issue with building gpu drivers on rl8 Dec 13, 2023
@LujieDuan LujieDuan force-pushed the lujieduan-fix-rl8-nvidia-driver branch from eede401 to 34988d0 Compare December 13, 2023 18:55
@LujieDuan LujieDuan marked this pull request as ready for review December 13, 2023 18:55
igorpeshansky
igorpeshansky reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM; one question.

integration_test/third_party_apps_data/applications/nvml/centos_rhel/install Outdated Show resolved Hide resolved
@LujieDuan LujieDuan force-pushed the lujieduan-fix-rl8-nvidia-driver branch from c074faf to cc9bae2 Compare December 13, 2023 19:32
@LujieDuan LujieDuan force-pushed the lujieduan-fix-rl8-nvidia-driver branch from cc9bae2 to 9c8645d Compare December 13, 2023 21:14
igorpeshansky
igorpeshansky approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of optional comments; otherwise LGTM :shipit:

integration_test/third_party_apps_data/applications/nvml/centos_rhel/install Outdated Show resolved Hide resolved
integration_test/third_party_apps_data/applications/nvml/centos_rhel/install Outdated Show resolved Hide resolved
@LujieDuan LujieDuan merged commit 1042f6c into master Dec 13, 2023
29 of 51 checks passed
@LujieDuan LujieDuan deleted the lujieduan-fix-rl8-nvidia-driver branch December 13, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LujieDuan @igorpeshansky