Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/Sub: please add DLQ samples for Pub/Sub #1178

Closed
anguillanneuf opened this issue Sep 21, 2020 · 2 comments · Fixed by #1230
Closed

Pub/Sub: please add DLQ samples for Pub/Sub #1178

anguillanneuf opened this issue Sep 21, 2020 · 2 comments · Fixed by #1230
Assignees
@jdpedrie
Labels
samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@anguillanneuf
Copy link
Member

anguillanneuf commented Sep 21, 2020 •
edited
Loading

Please add samples for

  1. create a subscription with a dead letter policy: pubsub_dead_letter_create_subscription
  2. update a subscription's dead letter policy: pubsub_dead_letter_update_subscription
  3. remove a subscription's dead letter policy: pubsub_dead_letter_remove
  4. show the delivery attempt field in received messages: pubsub_dead_letter_delivery_attempt

See existing Java, Go, Python, Node samples.
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 21, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 22, 2020
@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 22, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Sep 22, 2020
@anguillanneuf anguillanneuf changed the title samples: please add DLQ samples for Pub/Sub Pub/Sub: please add DLQ samples for Pub/Sub Sep 28, 2020
@anguillanneuf anguillanneuf mentioned this issue Sep 29, 2020
Open
@anguillanneuf
Copy link
Member Author

Is this work still being planned?

@jdpedrie
Copy link
Contributor

Thanks for the reminder, and sorry for the delay. This sorta fell off my radar. I'm working on it today.

@jdpedrie jdpedrie mentioned this issue Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdpedrie jdpedrie

Labels
samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add dead letter queue samples jdpedrie/php-docs-samples
4 participants
@jdpedrie @bshaffer @anguillanneuf @yoshi-automation