Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample: add samples for dead letter topics #1010

Merged
merged 6 commits into from
Jun 1, 2020

Conversation

laljikanjareeya
Copy link
Contributor

Fixes #947

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2020
@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2020
@feywind
Copy link
Collaborator

feywind commented May 27, 2020

@laljikanjareeya Thanks so much for adding these! It looks like the CI is acting up. Let me try another re-run.

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2020
@feywind
Copy link
Collaborator

feywind commented May 27, 2020

Ah, this is holding it up. #1009

@feywind
Copy link
Collaborator

feywind commented May 30, 2020

@laljikanjareeya Looks like there's one actual error in the sample test:

       should create a subscription with dead lettter policy.:
     AssertionError: expected '' to include 'Created subscription sub5-03fe7499-8fe0-45ba-8aa7-f2f5399f496d with dead letter topic topic3-03fe7499-8fe0-45ba-8aa7-f2f5399f496d.'
      at Context.it (system-test/subscriptions.test.js:299:12)

Oh, a typo in the title of the test too. Thanks GitHub :)

Otherwise this looks pretty good to me.

@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2020
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #1010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          22       22           
  Lines       10615    10615           
  Branches      509      466   -43     
=======================================
  Hits        10107    10107           
  Misses        505      505           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8ced3...41aff82. Read the comment docs.

@laljikanjareeya
Copy link
Contributor Author

Thanks @feywind for the review I fix the given changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add samples for dead letter queues feature
5 participants