Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/Sub: please add DLQ samples #594

Closed
3 of 4 tasks
anguillanneuf opened this issue Jun 1, 2020 · 5 comments · Fixed by #700
Closed
3 of 4 tasks

Pub/Sub: please add DLQ samples #594

anguillanneuf opened this issue Jun 1, 2020 · 5 comments · Fixed by #700
Assignees
@quartzmo
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@anguillanneuf
Copy link
Member

anguillanneuf commented Jun 1, 2020 •
edited by quartzmo
Loading

Please add samples for

  • create a subscription with a dead letter policy - pubsub_dead_letter_create_subscription
  • update a subscription's dead letter policy - pubsub_dead_letter_update_subscription
  • remove a subscription's dead letter policy - pubsub_dead_letter_remove
  • receive messages that have a delivery attempts field - pubsub_dead_letter_delivery_attempt

See existing Java, Go, Python, Node samples for how to name region tags.
@quartzmo
Copy link
Member

quartzmo commented Jun 1, 2020

Removing a subscription's dead letter policy is currently blocked by googleapis/google-cloud-ruby#6159. I'll try to get a fix for that issue done by the end of this week.

@quartzmo quartzmo added the api: pubsub Issues related to the Pub/Sub API. label Jun 1, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 2, 2020
@quartzmo quartzmo added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 2, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jun 2, 2020
@quartzmo
Copy link
Member

quartzmo commented Jun 2, 2020

PR for removing a subscription's dead letter policy in progress: googleapis/google-cloud-ruby#6314

@quartzmo
Copy link
Member

The best approach to removing a dead letter policy is still being evaluated. Here is an alternative PR to the one above: googleapis/google-cloud-ruby#6462

@anguillanneuf
Copy link
Member Author

Thank you @quartzmo for the update!

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 28, 2020
@anguillanneuf
Copy link
Member Author

Bump.

@anguillanneuf anguillanneuf mentioned this issue Sep 28, 2020
Closed
3 tasks
quartzmo added a commit to quartzmo/ruby-docs-samples that referenced this issue Oct 16, 2020
@quartzmo
pubsub: Add dead letter policy (DLQ) samples
71c8daa 
* Add pubsub_dead_letter_create_subscription
* Add pubsub_dead_letter_update_subscription
* Add pubsub_dead_letter_delivery_attempt

refs: GoogleCloudPlatform#594
quartzmo added a commit to quartzmo/ruby-docs-samples that referenced this issue Oct 16, 2020
@quartzmo
pubsub: Add dead letter policy (DLQ) samples
82a5084 
* Add pubsub_dead_letter_create_subscription
* Add pubsub_dead_letter_update_subscription
* Add pubsub_dead_letter_delivery_attempt

refs: GoogleCloudPlatform#594
@quartzmo quartzmo mentioned this issue Oct 16, 2020
Merged
quartzmo added a commit that referenced this issue Oct 23, 2020
@quartzmo
pubsub: Add DLQ, detach, error and lease samples
45af626 
* Add pubsub_dead_letter_create_subscription
* Add pubsub_dead_letter_update_subscription
* Add pubsub_dead_letter_delivery_attempt
* Add pubsub_detach_subscription sample
* Add pubsub_publish_with_error_handler
* Add pubsub_subscriber_sync_pull_with_lease
* Remove pubsub_subscriber_sync_pull_custom_attributes region tag

refs: #594
closes: #628
closes: #669
quartzmo added a commit to quartzmo/ruby-docs-samples that referenced this issue Nov 11, 2020
@quartzmo
feat(pubsub): Add pubsub_dead_letter_remove
5c20468 
closes: GoogleCloudPlatform#594
@quartzmo quartzmo mentioned this issue Nov 11, 2020
Merged
quartzmo added a commit that referenced this issue Nov 13, 2020
@quartzmo
feat(pubsub): Add pubsub_dead_letter_remove (#700)
54bf6e7 
closes: #594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pubsub): Add pubsub_dead_letter_remove quartzmo/ruby-docs-samples
3 participants
@quartzmo @anguillanneuf @yoshi-automation