Skip to content

Commit

Permalink
add clarifying language to contributing.md (#3303)
Browse files Browse the repository at this point in the history
Added clarifying language about reviewers after a discussion in the On Ramp chat this morning. I originally thought this was going in the authoring guide, which is why my branch is called that, but changed my mind. 🙈
  • Loading branch information
leahecole committed Apr 10, 2020
1 parent 596602f commit 1d417b5
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@ be able to accept your pull requests.
## Authoring, testing, and contributing samples

See [AUTHORING_GUIDE.md](AUTHORING_GUIDE.md).

## Code Reviews

After meeting the above criteria, your code will need to be approved by two reviewers before it can be merged into master. One will be a [CODEOWNER](.github/CODEOWNERS) for the product you are contributing to, and the other will be a repo owner, there to double check for anything that might be detrimental to the overall repo health (things that could cause future tech debt, test flakiness, etc.). Both will automatically be assigned. Some product areas have mulitple folks who can act as the CODEOWNER, and you may be working more closely with a teammate who isn't the automatically assigned reviewer. In that case, it is perfectly fine to manually assign the teammate more familiar with this work as your CODEOWNER reviewer. If you do not hear from your repo owner reviewer within a day (and you know they are not OOO), send them a friendly ping so that you can better understand the review cadence for your PR. All the repo owners are juggling reviews alongside other work, and their velocities can vary, but they are happy to hear from you. If you see that your repo owner reviewer is OOO, you can use the "blunderbuss: assign" label to assign a new reviewer.

0 comments on commit 1d417b5

Please sign in to comment.