automl beta #1575
automl beta #1575
Conversation
googlebot
added
the
cla: yes
sirtorry
force-pushed
the
automl
branch
4 times, most recently
from
23d0f49
to
8153edf
Compare
| client = automl.AutoMlClient() | ||
|
|
||
| # Get the latest state of a long-running operation. | ||
| response = client.transport._operations_client.get_operation( |
There was a problem hiding this comment.
Can you explain why you need to be able to get the operation status? If you think there is a legitimate use case for this we may want to consider adding a method on the client object for this, since you are relying on an internal object here.
There was a problem hiding this comment.
these training jobs can be long running, up to a day.
There was a problem hiding this comment.
Alright. I am going to create an issue on the library for us to consider this as a change. Thanks!
There was a problem hiding this comment.
I am not 100% sure but I think response.operation.refresh() will give the current status.
There was a problem hiding this comment.
what would response be in response.operation.refresh()?
| @@ -0,0 +1,300 @@ | |||
| #!/usr/bin/env python | |||
|
|
|||
| # Copyright 2018 Google Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
I was told we are supposed to start using LLC instead of Inc from now on.
| https://cloud.google.com/natural-language/automl/docs/ | ||
| """ | ||
|
|
||
| # [START automl_natural_language_import] |
There was a problem hiding this comment.
Do we need region tags for imports too? I did not know.
| # [END automl_natural_language_import] | ||
|
|
||
|
|
||
| # [START automl_natural_language_create_dataset] |
There was a problem hiding this comment.
Tim Swast advised me to put the region tags inside the function body. He told me this is the new standard.
| import argparse | ||
| import os | ||
|
|
||
| from google.cloud import automl_v1beta1 as automl |
There was a problem hiding this comment.
I believe for samples this import should be inside the function body. That way then the code snippet is selected using the region tags, the imports will also be included in the selected snippet.
| Default is False. | ||
| """ | ||
| client = automl.AutoMlClient() | ||
|
|
There was a problem hiding this comment.
You need these comment lines here (or something like this):
# TODO(developer): Uncomment and set to a path to your audio file.
# project_id = 'PROJECT_ID_HERE'
# compute_region = 'COMPUTE_REGION_HERE'
# dataset_name = 'DATASET_NAME_HERE'
The reason is that once the function body is selected to be shown in some web page using the region tags, these comments tell the user what these parameters should be.
| # Classification type is assigned based on multilabel value. | ||
| classification_type = "MULTICLASS" | ||
| if multilabel: | ||
| classification_type = "MULTILABEL" |
There was a problem hiding this comment.
Nothing wrong with the lines above, a more compact way is of course:
classification_type = "MULTILABEL" if multilabel else "MULTICLASS"
There was a problem hiding this comment.
doesn't really affect snippet quality or functionality. won't fix.
| # [END automl_natural_language_create_dataset] | ||
|
|
||
|
|
||
| # [START automl_natural_language_list_datasets] |
There was a problem hiding this comment.
Same as above comments. Region tag should be inside the function body.
| print("\tnanos: {}".format(dataset.create_time.nanos)) | ||
|
|
||
|
|
||
| # [END automl_natural_language_list_datasets] |
There was a problem hiding this comment.
This too should be inside the function
| args = parser.parse_args() | ||
|
|
||
| if args.command == "create_dataset": | ||
| multilabel = True if args.multilabel == "True" else False |
There was a problem hiding this comment.
This line can be simplified to:
multilabel = (args.multilabel == "True")
There was a problem hiding this comment.
doesn't affect snippet quality or functionality. won't fix.
| args = parser.parse_args() | ||
|
|
||
| if args.command == "create_dataset": | ||
| multilabel = True if args.multilabel == "True" else False |
There was a problem hiding this comment.
This line can be simplified to:
multilabel = (args.multilabel == "True")
There was a problem hiding this comment.
doesn't affect snippet quality or functionality. won't fix.
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
* automl initial commit * lint * fix import groupings * add requirements.txt * address review comments
add automl samples and tests