Language region tag update #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dizcology
reviewed
Aug 21, 2018
language/cloud-client/v1/snippets.py
Outdated
|
|
||
|
|
||
| # [START def_sentiment_file] | ||
| # [START language_sentiment_file_gcs] |
There was a problem hiding this comment.
should this be just the gcs suffix instead of file_gcs?
There was a problem hiding this comment.
To be consistent with the other samples, there is a _gcs suffix when the file is from GCS, and no suffix when it is a local file.
dizcology
approved these changes
Aug 21, 2018
busunkim96
pushed a commit
to busunkim96/python-language
that referenced
this pull request
May 20, 2020
hkdevandla
pushed a commit
to hkdevandla/python-language
that referenced
this pull request
Sep 26, 2020
busunkim96
pushed a commit
to googleapis/python-language
that referenced
this pull request
Sep 29, 2020
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
8 tasks
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates region tags to be consistent with those in other languages. Region tag update on cloud.google.com is also in progress and will be submitted after all language PRs are merged.