Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decode #1911

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Fix decode #1911

merged 4 commits into from
Dec 6, 2018

Conversation

andrewferlitsch
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 6, 2018
hongalex
hongalex approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hongalex hongalex added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 6, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@hongalex hongalex merged commit 56e1b34 into master Dec 6, 2018
@hongalex hongalex deleted the fix_decode branch December 6, 2018 23:55
busunkim96 pushed a commit to busunkim96/python-language that referenced this pull request May 20, 2020
@andrewferlitsch
Fix decode [(#1911)](GoogleCloudPlatform/python-docs-samples#1911)
38ba307 
* fix decode problem

* fix decode

* fix decode
hkdevandla pushed a commit to hkdevandla/python-language that referenced this pull request Sep 26, 2020
@andrewferlitsch
Fix decode [(#1911)](GoogleCloudPlatform/python-docs-samples#1911)
3306b08 
* fix decode problem

* fix decode

* fix decode
busunkim96 pushed a commit to googleapis/python-language that referenced this pull request Sep 29, 2020
@andrewferlitsch @busunkim96
Fix decode [(#1911)](GoogleCloudPlatform/python-docs-samples#1911)
02eaf3b 
* fix decode problem

* fix decode

* fix decode
m-strzelczyk pushed a commit that referenced this pull request Nov 18, 2022
@andrewferlitsch @busunkim96
Fix decode [(#1911)](#1911)
5fb10cf 
* fix decode problem

* fix decode

* fix decode
@m-strzelczyk m-strzelczyk mentioned this pull request Nov 18, 2022
Merged
8 tasks
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
@andrewferlitsch @busunkim96
Fix decode [(#1911)](GoogleCloudPlatform/python-docs-samples#1911)
7c0fc56 
* fix decode problem

* fix decode

* fix decode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewferlitsch @googlebot @hongalex