Add google cloud storage samples using gcloud. #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple upload and download samples using python gcloud.
googlebot
added
the
cla: yes
|
|
||
| # You can (and should) generate your own encryption key. os.urandom(32) is a | ||
| # good way to accomplish this with Python. | ||
| # Although these keys are provided here for simplicity, please remember |
|
I would prefer that we update all of the cloud storage samples at once to use gcloud-python, however, this would need better coordination. |
|
Thank you for the super quick turnaround. I incorporated your suggestions to the change. PTAL. |
| # | ||
| # Although these keys are provided here for simplicity, please remember | ||
| # that it is a bad idea to store your encryption keys in your source code. | ||
| ENCRYPTION_KEY = os.urandom(32) |
There was a problem hiding this comment.
Might be worth pointing out explicitly that it MUST be exactly 256 bits.
|
Updated with improvements per feedback. PTAL. |
|
LGTM |
|
Thanks. Do you know what the Travis-ci error means? Quoted: |
|
Travis doesn't succeed for outside pull requests, it's expected. |
dizcology
pushed a commit
that referenced
this pull request
Sep 11, 2023
9 tasks
leahecole
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple upload and download samples using python gcloud.