Update logging samples to fit new style guide and match Node.js samples. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Sorry for the big change, I screwed myself because I wrote half of these before I realized there were existing samples. |
|
This is going to break the include tags on https://cloud.google.com/logging/docs/api/tasks/creating-logs |
|
I know, I'll handle updating docs. |
theacodes
force-pushed
the
logging-samples-update
branch
from
fd53bd3
to
3e98e9e
Compare
|
|
||
| print('Latest entries for logger {}:'.format(logger.name)) | ||
|
|
||
| entries, token = logging_client.list_entries( |
There was a problem hiding this comment.
Two things:
-
If you don't loop on the token, you're going to have a bad time. The API will return 0 entries at first then return 5 on the next one, the token is also used to indicate "loading"
-
You should just be able to do logger.list() now. There was a gcloud-python bug I fixed that should be released now)
added 2 commits
August 3, 2016 10:05
Change-Id: I88ff16ebfd4fc2aac6413f97acd43482b15f9cdc
Change-Id: I33928ebde19a29074ac00a26b1eb4bcffe597bfd
theacodes
force-pushed
the
logging-samples-update
branch
from
3e98e9e
to
ade603b
Compare
|
@waprin updated, PTAL. |
| assert example_sink.filter_ == updated_filter | ||
|
|
||
|
|
||
| def ttest_delete(example_sink, capsys): |
Change-Id: Ica6bf512afa3cd307a52d4726cf6629ef8678339
| @@ -1,4 +1,10 @@ | |||
| # Cloud Storage API Samples | |||
| # Stackdriver Logging v1 Samples | |||
There was a problem hiding this comment.
I think you messed something up, this is the storage README
Change-Id: I7304e8378e43ebf5ed6c8806b0efd52cacc44310
| @@ -1,17 +1,28 @@ | |||
| # Google Cloud Logging v1 Samples | |||
| # Stackdriver Logging v1 Samples | |||
|
|
|||
| **Note that these samples are for the v1 Samples, using the Google API Client. | |||
| It's recommended you instead use the [Logging v2 samples](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/logging/api), which use the Google | |||
| Cloud client library.** | |||
|
|
|||
| This section contains samples for [Google Cloud Logging](https://cloud.google.com/logging). | |||
There was a problem hiding this comment.
s/Google Cloud/Stackdriver/
?
|
code lgtm, offline organization comments |
Change-Id: Ib6cf1f2d6e9009058ff93d199ad4ffb527208d47
busunkim96
pushed a commit
to busunkim96/python-logging
that referenced
this pull request
Oct 12, 2020
busunkim96
pushed a commit
to busunkim96/python-logging
that referenced
this pull request
Oct 30, 2020
busunkim96
pushed a commit
to googleapis/python-logging
that referenced
this pull request
Oct 30, 2020
holtskinner
pushed a commit
that referenced
this pull request
Jan 3, 2023
8 tasks
holtskinner
pushed a commit
that referenced
this pull request
Jan 4, 2023
dandhlee
pushed a commit
that referenced
this pull request
Jan 5, 2023
dizcology
pushed a commit
that referenced
this pull request
Sep 11, 2023
…1.3 (#435) Co-authored-by: Anthonios Partheniou <partheniou@google.com>
9 tasks
leahecole
pushed a commit
that referenced
this pull request
Sep 15, 2023
…1.3 (#435) Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.