Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minitest::Result: test_0001_supports pubsub_update_push_configuration, pubsub_list_subscriptions, pubsub_set_subscription_policy, pubsub_get_subscription_policy, pubsub_test_subscription_permissions, pubsub_detach_subscription, pubsub_delete_subscription failed #697

Closed
flaky-bot bot opened this issue Nov 2, 2020 · 5 comments · Fixed by #701 or #707
Closed

Minitest::Result: test_0001_supports pubsub_update_push_configuration, pubsub_list_subscriptions, pubsub_set_subscription_policy, pubsub_get_subscription_policy, pubsub_test_subscription_permissions, pubsub_detach_subscription, pubsub_delete_subscription failed #697

flaky-bot bot opened this issue Nov 2, 2020 · 5 comments · Fixed by #701 or #707
Assignees
@quartzmo
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Nov 2, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

commit: b540c9c
buildURL: Build Status, Sponge
status: failed

Test output
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/assertions.rb:183:in `assert'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/assertions.rb:218:in `assert_equal'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/assertions.rb:341:in `assert_output'
/tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:76:in `block (2 levels) in '
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:98:in `block (3 levels) in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:195:in `capture_exceptions'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:95:in `block (2 levels) in run'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:38:in `block (2 levels) in time_it'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:31:in `around'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:37:in `block in time_it'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:272:in `time_it'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:36:in `time_it'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:94:in `block in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:367:in `on_signal'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:211:in `with_info_handler'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:93:in `run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:1029:in `run_one_method'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:341:in `run_one_method'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:328:in `block (2 levels) in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:327:in `each'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:327:in `block in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:367:in `on_signal'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:354:in `with_info_handler'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:81:in `block in with_info_handler'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:26:in `around_all'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:70:in `with_info_handler'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:326:in `run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:164:in `block in __run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:164:in `map'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:164:in `__run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:141:in `run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:68:in `block in autorun'
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 2, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Nov 3, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (b540c9c), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Nov 8, 2020
@TheRoyalTnetennba TheRoyalTnetennba added the api: pubsub Issues related to the Pub/Sub API. label Nov 11, 2020
@quartzmo quartzmo mentioned this issue Nov 13, 2020
Merged
@quartzmo
Copy link
Member

Details from the build output linked above:

# Running:

.failed attempt 1 for pubsub_publish_with_ordering_keys
....failed attempt 1 for pubsub_publish
....failed attempt 1 for pubsub_subscriber_sync_pull
.....EF..

Finished in 466.164118s, 0.0386 runs/s, 0.2960 assertions/s.

  1) Error:
subscriptions#test_0007_supports pubsub_subscriber_sync_pull_with_lease:
Google::Cloud::InvalidArgumentError: 3:You have passed a subscription that does not belong to the given ack ID (resource=projects/cloud-samples-ruby-test-2/subscriptions/ruby-pubsub-samples-test-subscription-f708377e).. debug_error_string:{"created":"@1604347451.206354883","description":"Error received from peer ipv4:74.125.139.95:443","file":"src/core/lib/surface/call.cc","file_line":1062,"grpc_message":"You have passed a subscription that does not belong to the given ack ID (resource=projects/cloud-samples-ruby-test-2/subscriptions/ruby-pubsub-samples-test-subscription-f708377e).","grpc_status":3}
    /usr/local/bundle/gems/google-cloud-pubsub-v1-0.1.2/lib/google/cloud/pubsub/v1/subscriber/client.rb:805:in `rescue in modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-v1-0.1.2/lib/google/cloud/pubsub/v1/subscriber/client.rb:771:in `modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-2.1.1/lib/google/cloud/pubsub/service.rb:249:in `modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-2.1.1/lib/google/cloud/pubsub/subscription.rb:1004:in `modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-2.1.1/lib/google/cloud/pubsub/received_message.rb:221:in `modify_ack_deadline!'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:336:in `block in subscriber_sync_pull_with_lease'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:326:in `loop'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:326:in `subscriber_sync_pull_with_lease'
    /tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:154:in `block (4 levels) in <top (required)>'

  2) Failure:
subscriptions#test_0001_supports pubsub_update_push_configuration, pubsub_list_subscriptions, pubsub_set_subscription_policy, pubsub_get_subscription_policy, pubsub_test_subscription_permissions, pubsub_detach_subscription, pubsub_delete_subscription [/tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:76]:
In stdout.
--- expected
+++ actual
@@ -1,4 +1,3 @@
-# encoding: UTF-8
-#    valid: true
-"Subscription is detached.
+"Finished processing \"This is a test message.\".
+Subscription is detached.
 "


18 runs, 138 assertions, 1 failures, 1 errors, 0 skips

### Tests for pubsub took 466 seconds ###

quartzmo added a commit to quartzmo/ruby-docs-samples that referenced this issue Nov 13, 2020
@quartzmo
pubsub(chore): Add sleep to expect_with_retry in tests
2c82095 
closes: GoogleCloudPlatform#696
closes: GoogleCloudPlatform#697
@quartzmo quartzmo mentioned this issue Nov 13, 2020
Merged
quartzmo added a commit that referenced this issue Nov 13, 2020
@quartzmo
pubsub(chore): Add sleep to expect_with_retry in tests
f1b766d 
closes: #696
closes: #697
pr: #701
@flaky-bot
Copy link
Author

flaky-bot bot commented Nov 18, 2020

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

commit: f1b766d
buildURL: Build Status, Sponge
status: failed

Test output
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/assertions.rb:183:in `assert'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/assertions.rb:218:in `assert_equal'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/assertions.rb:341:in `assert_output'
/tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:76:in `block (2 levels) in '
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:98:in `block (3 levels) in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:195:in `capture_exceptions'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:95:in `block (2 levels) in run'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:38:in `block (2 levels) in time_it'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:31:in `around'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:37:in `block in time_it'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:272:in `time_it'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:36:in `time_it'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:94:in `block in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:367:in `on_signal'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:211:in `with_info_handler'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest/test.rb:93:in `run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:1029:in `run_one_method'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:341:in `run_one_method'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:328:in `block (2 levels) in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:327:in `each'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:327:in `block in run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:367:in `on_signal'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:354:in `with_info_handler'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:81:in `block in with_info_handler'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:26:in `around_all'
/usr/local/bundle/gems/minitest-hooks-1.5.0/lib/minitest/hooks/test.rb:70:in `with_info_handler'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:326:in `run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:164:in `block in __run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:164:in `map'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:164:in `__run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:141:in `run'
/usr/local/bundle/gems/minitest-5.14.2/lib/minitest.rb:68:in `block in autorun'

@flaky-bot flaky-bot bot reopened this Nov 18, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 18, 2020
@quartzmo
Copy link
Member

Output from build linked above:

# Running:

.........failed attempt 1 for pubsub_publish_with_ordering_keys
....EF...

Finished in 442.915274s, 0.0406 runs/s, 0.3138 assertions/s.

  1) Error:
subscriptions#test_0007_supports pubsub_subscriber_sync_pull_with_lease:
Google::Cloud::InvalidArgumentError: 3:You have passed a subscription that does not belong to the given ack ID (resource=projects/cloud-samples-ruby-test-1/subscriptions/ruby-pubsub-samples-test-subscription-d551283a).. debug_error_string:{"created":"@1605729188.916188890","description":"Error received from peer ipv4:74.125.202.95:443","file":"src/core/lib/surface/call.cc","file_line":1062,"grpc_message":"You have passed a subscription that does not belong to the given ack ID (resource=projects/cloud-samples-ruby-test-1/subscriptions/ruby-pubsub-samples-test-subscription-d551283a).","grpc_status":3}
    /usr/local/bundle/gems/google-cloud-pubsub-v1-0.1.2/lib/google/cloud/pubsub/v1/subscriber/client.rb:805:in `rescue in modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-v1-0.1.2/lib/google/cloud/pubsub/v1/subscriber/client.rb:771:in `modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-2.2.0/lib/google/cloud/pubsub/service.rb:249:in `modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-2.2.0/lib/google/cloud/pubsub/subscription.rb:1042:in `modify_ack_deadline'
    /usr/local/bundle/gems/google-cloud-pubsub-2.2.0/lib/google/cloud/pubsub/received_message.rb:221:in `modify_ack_deadline!'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:349:in `block in subscriber_sync_pull_with_lease'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:339:in `loop'
    /tmpfs/src/github/ruby-docs-samples/pubsub/subscriptions.rb:339:in `subscriber_sync_pull_with_lease'
    /tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:154:in `block (4 levels) in <top (required)>'

  2) Failure:
subscriptions#test_0001_supports pubsub_update_push_configuration, pubsub_list_subscriptions, pubsub_set_subscription_policy, pubsub_get_subscription_policy, pubsub_test_subscription_permissions, pubsub_detach_subscription, pubsub_delete_subscription [/tmpfs/src/github/ruby-docs-samples/pubsub/acceptance/subscriptions_test.rb:76]:
In stdout.
--- expected
+++ actual
@@ -1,4 +1,3 @@
-# encoding: UTF-8
-#    valid: true
-"Subscription is detached.
+"Finished processing \"This is a test message.\".
+Subscription is detached.
 "


18 runs, 139 assertions, 1 failures, 1 errors, 0 skips

@quartzmo
Copy link
Member

Failure 2) above is a side-effect of failure 1). (The output from a worker thread in 1) was captured in 2).

quartzmo added a commit to quartzmo/ruby-docs-samples that referenced this issue Nov 18, 2020
@quartzmo
pubsub(chore): Ensure subscription isolation for each test
db27209 
closes GoogleCloudPlatform#697
@quartzmo quartzmo mentioned this issue Nov 18, 2020
Closed
quartzmo added a commit to quartzmo/ruby-docs-samples that referenced this issue Nov 18, 2020
@quartzmo
pubsub(chore): Fix subscriptions_test.rb
f5100a5 
* Ensure subscription isolation for each test
* Sleep 5 after publishing test message

closes: GoogleCloudPlatform#697
closes: GoogleCloudPlatform#702
@quartzmo quartzmo mentioned this issue Nov 18, 2020
Merged
quartzmo added a commit that referenced this issue Nov 19, 2020
@quartzmo
pubsub(chore): Fix subscriptions_test.rb
1fa0075 
* Ensure subscription isolation for each test
* Sleep 5 after publishing test message

closes: #697
closes: #702
pr: #707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@quartzmo @TheRoyalTnetennba @yoshi-automation