samples: allow multiple KMS keys to create CMEK database/backup #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
samples
dazuma
requested changes
Sep 4, 2024
|
Thank you @dazuma, PTAL. |
dazuma
changed the title
dazuma
requested changes
Sep 12, 2024
|
I have addressed the feedback. PTAL. |
dazuma
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dazuma
reviewed
Sep 13, 2024
| @@ -33,8 +33,19 @@ | |||
| @restored_database_id = "restored_db_#{seed}" | |||
| @spanner = Google::Cloud::Spanner.new project: @project_id | |||
| @instance = @spanner.instance @instance_id | |||
| @mr_instance_id = "rb-test-#{seed}" | |||
| # Create multi-region instance for CMEK | |||
| create_instance @project_id, @mr_instance_id, "nam3" | |||
There was a problem hiding this comment.
This line is erroring now in the tests, because the arguments are supposed to be keyword arguments rather than positional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kms_key_names field to create database/create backup code snippets.