Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.containterignore #1734

Open
pierreyves-lebrun opened this issue Sep 8, 2021 · 3 comments · May be fixed by #3305
Open

.containterignore #1734

pierreyves-lebrun opened this issue Sep 8, 2021 · 3 comments · May be fixed by #3305
Labels
area/cli bugs related to kaniko CLI area/filesystems For all bugs related to kaniko container filesystems (mounting issues etc) area/usability For all bugs related to how people use kaniko, option and feature flags, etc good first issue Good for newcomers help wanted Looking for a volunteer! kind/feature-request priority/p2 High impact feature/bug. Will get a lot of users happy

Comments

@pierreyves-lebrun
Copy link

Actual behavior
Kaniko currently expects .dockerignore file for excluding files/folders from image builds.

Expected behavior
As the industry is moving away from Docker, it would be nice to support .containerignore as an alternate filename.

Additional Information
Would you accept a PR that moves the currently hard coded .dockerignore value to a command line argument?

Description Yes/No
Please check if this a new feature you are proposing
Please check if the build works in docker but not in kaniko
Please check if this error is seen when you use --cache flag
Please check if your dockerfile is a multistage dockerfile
@aaron-prindle aaron-prindle added kind/feature-request priority/p2 High impact feature/bug. Will get a lot of users happy area/usability For all bugs related to how people use kaniko, option and feature flags, etc area/cli bugs related to kaniko CLI area/filesystems For all bugs related to kaniko container filesystems (mounting issues etc) good first issue Good for newcomers help wanted Looking for a volunteer! labels May 30, 2023
@ebousse
Copy link

ebousse commented Aug 23, 2023

For reference, this is already supported by Podman, and indeed would be great to see in kaniko :)

@bncmajor
Copy link

bncmajor commented Aug 29, 2024

podman supports both, and if both are present it uses the .containerignore only.
is this the behavior what would be the end goal here too?

I'd be happy to take this task on as my first issue

@pierreyves-lebrun
Copy link
Author

podman supports both, and if both are present it uses the .containerignore only. is this the behavior what would be the end goal here too?

I'd be happy to take this task on as my first issue

Yes I think mimicking podman behavior would be great

@bncmajor bncmajor linked a pull request Aug 30, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bugs related to kaniko CLI area/filesystems For all bugs related to kaniko container filesystems (mounting issues etc) area/usability For all bugs related to how people use kaniko, option and feature flags, etc good first issue Good for newcomers help wanted Looking for a volunteer! kind/feature-request priority/p2 High impact feature/bug. Will get a lot of users happy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants