integration: test case for HOME

[greut]

Description

According to #824, #1097 and #995, the $HOME variable should be set and correct when using USER.

Is it a limitation of the design? If not, do you see a way to get this fixed? If yes, any guidance would be appreciated to give a hand in the area.

Cheers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- integration test to ensure the `HOME` variable is properly filled by `USER`

[cvgw]

This is the same bug as #1082

[tejal29]

@greut Thank you for looking into this and submitting this PR.

I think the culprit here is addDefaultHOME function.

In this func at L106, we return immediately if HOME is set in the environmental variables there way ignoring the change in the USER config.
We should change that to

1. Evaluate HOME from user string passed like L119
2. Update the HOME variable if present in the env or append it.

Since this is a critical bug, we would like to get this in before next release. Let us know if you need any help finishing this PR.

Thanks
Tejal

[greut]

Iirc test is posix, not bash.

…

On Thu, Feb 27, 2020 at 20:49, Tejal Desai ***@***.***> wrote: @tejal29 commented on this pull request. --------------------------------------------------------------- In [integration/dockerfiles/Dockerfile_test_user_home](#1072 (comment)): > +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM debian:9.11 + +# default values for the root user. +RUN test "/root" = "$HOME" && \ please remove bash test . — You are receiving this because you were mentioned. Reply to this email directly, [view it on GitHub](#1072?email_source=notifications&email_token=AAAAK3EHUO3JMTRAZ2JELCLRFAKLDA5CNFSM4KZ36UKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXH7PBY#pullrequestreview-365950855), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAAK3FXU2B7ZPXD5RAHIJ3RFAKLDANCNFSM4KZ36UKA).

[tejal29]

Iirc test is posix, not bash.

Ack. I meant assertions inside Dockerfile.

[tejal29]

@greut would you like to also add the fix to the code so your test pass?
You can follow the hints here #1072 (comment)

Let me know if you need more help.

[greut]

touch: cannot touch '//hello': Permission denied better, we are close.

[greut]

@tejal29 The issue at hands is being able to read the /etc/passwd from the current state of the filesystem. Any ideas how this is doable? I should have read the design docs way earlier 😉

[tejal29]

explanation for a corner case.

[tejal29]

Thanks @greut I am going to rebase your PR and resolve conflicts. Hopefully your branch will be green now.

[greut]

👍

[tejal29]

Now we are seeing the error where Group is not user group.

            INFO[0008] RUN touch $HOME/hello                        
            INFO[0008] cmd: /bin/sh                                 
            INFO[0008] args: [-c touch $HOME/hello]                 
            touch: cannot touch '//hello': Permission denied
            error building image: error building stage: failed to execute command: waiting for process to exit: exit status 1

[greut]

@tejal29 I would have preferred a merge over that rebase to be frank.

[greut]

wooooooooooohooo 😜