Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Kaniko to test across multistages #1155

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Refactor Kaniko to test across multistages #1155

merged 5 commits into from
Mar 30, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Mar 24, 2020 •
edited
Loading

Relates to #1111 (comment)

In this PR, added an ability to unit test across stages by

  1. Overriding ROOT_DIR , KANIKO_DIR to point to a tmp dir
  2. Added more tests
  3. Wrapped error wherever possible.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Mar 24, 2020
@tejal29 tejal29 changed the title Refactor Kaniko to Refactor Kaniko to test across multistages Mar 24, 2020
@tejal29
Copy link
Member Author

tejal29 commented Mar 25, 2020 •
edited
Loading

The Travis CI passed for this PR here https://travis-ci.org/github/GoogleContainerTools/kaniko/builds/666909464?utm_medium=notification&utm_source=github_status

Please ignore Kokoro test results.

@tejal29 tejal29 merged commit 8dc6454 into GoogleContainerTools:master Mar 30, 2020
@gilbsgilbs gilbsgilbs mentioned this pull request Mar 31, 2020
Merged
4 tasks
@tejal29 tejal29 deleted the fix_multi_stage_symlinks branch April 26, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejal29 @googlebot