Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http support for git repository context #1196

Merged
merged 8 commits into from
May 4, 2020
Merged

Add http support for git repository context #1196

merged 8 commits into from
May 4, 2020

Conversation

yw-liu
Copy link
Contributor

@yw-liu yw-liu commented Apr 14, 2020

Description

In developing or testing environment, add http support for Git Repository context would be helpful.

Usage: set the GIT_PULL_METHOD env var to http or https when starting the container.

usage: set the GIT_PULL_METHOD env var to http or https for starting the container
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Apr 14, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Apr 16, 2020
func getGitPullMethod() string {
gitPullMethod := os.Getenv(gitPullMethodEnvKey)
if ok := supportedGitPullMethods[gitPullMethod]; !ok {
gitPullMethod = gitPullMethodHTTPS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gitPullMethod = gitPullMethodHTTPS
return gitPullMethodHTTPS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tejal29 for your suggestion, you may commit that.

@tejal29
Copy link
Member

tejal29 commented May 4, 2020

Thanks @yw-liu for your PR.

@tejal29 tejal29 merged commit fe0500f into GoogleContainerTools:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants