Bump the cosign version (a lot) #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For my next change I'm going to change this to sign digests instead of tags 😬 |
dlorenc
approved these changes
Dec 16, 2021
|
AIUI We do this in |
imjasonh
approved these changes
Dec 16, 2021
|
The KinD tests were timing out running the builds at 2m, so I bumped the timeout 🤞 |
|
I'm spinning up a new PR where I'm going to start debugging the e2e tests a bit |
The cosign version being used was ancient. This catches us up to 1.4.1 (latest). I was also eyeballing the very redundant jobs in `release.yaml` for a subsequent refactoring to make this a matrix job, so there are a couple of trivial cleanups related to this.
mattmoor
force-pushed
the
bump-cosign
branch
from
893cb8d
to
5c880d1
Compare
imjasonh
approved these changes
Dec 17, 2021
gcalmettes
pushed a commit
to gcalmettes/kaniko
that referenced
this pull request
Dec 24, 2021
The cosign version being used was ancient. This catches us up to 1.4.1 (latest). I was also eyeballing the very redundant jobs in `release.yaml` for a subsequent refactoring to make this a matrix job, so there are a couple of trivial cleanups related to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cosign version being used was ancient. This catches us up to 1.4.1 (latest).
I was also eyeballing the very redundant jobs in
release.yamlfor a subsequent refactoring to make this a matrix job, so there are a couple of trivial cleanups related to this.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes