Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canonical platform values. Fix 1995. #2025

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

gadiego92
Copy link
Contributor

Fixes #1995

Description

Prior to this change, Kaniko was not using the platform's canonical value.
On this PR Normalize function from containerd module is used to get the canonical platform. To get the platform value DefaultSpec has been replaced by DefaultSpec.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@google-cla
Copy link

google-cla bot commented Mar 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gadiego92 gadiego92 changed the title Fix 1995 Use canonical platform values. Fix 1995. Mar 31, 2022
cmd/executor/cmd/root.go Outdated Show resolved Hide resolved
Prior to this change, Kaniko was not using the platform's canonical value.
@imjasonh imjasonh merged commit 1b59a29 into GoogleContainerTools:main Mar 31, 2022
@imjasonh imjasonh mentioned this pull request Apr 1, 2022
@imjasonh imjasonh mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with 1.8.0, can not build image from multi-arch base: no child with platform
2 participants