Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache option for run command #2032

Merged

Conversation

RamyChaabane
Copy link
Contributor

@RamyChaabane RamyChaabane commented Apr 4, 2022

Fixes #2003

Description

This fix will add a flag to whether we want to cache layers from RUN command to a registry

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes
add a new flag

- kaniko adds a new flag `--cache-run-layers` to cache RUN layers 

@RamyChaabane RamyChaabane force-pushed the disable_cache_run_command branch 2 times, most recently from 2e2759a to 5be50df Compare April 5, 2022 09:52
@tejal29
Copy link
Member

tejal29 commented May 16, 2022

@RamyChaabane unit tests are failing.

@RamyChaabane
Copy link
Contributor Author

Hello @tejal29
it fails because I've added tests about the new flag, I didn't have much time to look it up, but I will resolve it ASAP

@imjasonh imjasonh merged commit f9dcb92 into GoogleContainerTools:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache-copy-layers disabled but not during multi-stage images ?
3 participants