Add --single-snapshot flag to snapshot once after the build #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Jun 13, 2018
integration/integration_test.go
Outdated
| @@ -106,6 +106,12 @@ func TestRun(t *testing.T) { | |||
| "Dockerfile_test_multistage": {"file=/foo2"}, | |||
| } | |||
|
|
|||
| // Map for additional flags | |||
There was a problem hiding this comment.
In the test somewhere it would be good to make sure there is only one additional layer. Any ideas?
There was a problem hiding this comment.
I added a test to make sure docker built and kaniko built images have the same number of layers (except for specified offsets for the --single-snapshot ones)
But it looks like it found errors in some of the other tests so I'll try and find those bugs as well
--- FAIL: TestLayers (96.89s)
--- FAIL: TestLayers/test_layer_dockerfiles/Dockerfile_test_user_run (1.70s)
integration_test.go:232: Error response from daemon: reference does not exist
--- FAIL: TestLayers/test_layer_dockerfiles/Dockerfile_test_volume (9.76s)
integration_test.go:232: incorrect offset between layers of gcr.io/kaniko-test/docker-dockerfile_test_volume and gcr.io/kaniko-test/kaniko-dockerfile_test_volume: expected 0 but got 2
--- FAIL: TestLayers/test_layer_dockerfiles/Dockerfile_test_workdir (9.78s)
integration_test.go:232: incorrect offset between layers of gcr.io/kaniko-test/docker-dockerfile_test_workdir and gcr.io/kaniko-test/kaniko-dockerfile_test_workdir: expected 0 but got 1
Does this need a rebase to pass? |
|
So these tests are failing because the number of layers is actually incorrect, but I found a bug for the workdir one which I'm going to submit a PR for now |
Merged
priyawadhwa
force-pushed
the
snapshot
branch
2 times, most recently
from
b1d2d99
to
77a4848
Compare
dlorenc
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203