Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(setup-minikube): use cri-dockerd #2149

Merged
merged 10 commits into from
Jun 27, 2022

Conversation

hown3d
Copy link
Contributor

@hown3d hown3d commented Jun 26, 2022

Signed-off-by: Höhl, Lukas lukas.hoehl@accso.de

Fixes minikube-setup error in CI pipeline.

Description

Kubernetes 1.24 removed dockershim support and the latest release of minikube defaults to creating clusters 1.24+. To continue using the none driver and docker, cri-dockerd is needed.

This PR installs the cri and crictl with the minikube-setup.sh script

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Höhl, Lukas added 10 commits June 26, 2022 15:18
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
Signed-off-by: Höhl, Lukas <lukas.hoehl@accso.de>
@hown3d hown3d changed the title fix(setup-minikube): use cri-dockerd ci(setup-minikube): use cri-dockerd Jun 27, 2022
@imjasonh imjasonh merged commit 4338275 into GoogleContainerTools:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants