Use correct media type for zstd layers #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous commits I forgot to override the media type for layers that are using zstd compression.
imjasonh
approved these changes
Apr 3, 2023
|
Thanks for approving so quickly @imjasonh 👍 Imo this can be merged whenever you're ready. Thanks again |
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
In my previous commits I forgot to override the media type for layers that are using zstd compression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an addendum to #2313 which ensures that kaniko uses correct media types when zstd compression is enabled. In my previous PR I forgot to take into account a change that I made in google/go-containerregistry#1487 which disabled automatic media type selection for zstd compressed layers (see google/go-containerregistry@e29dcb9).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes