Use a multistage image to remove all redundancies on Dockerfiles #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As all Kaniko variants should be upgraded at once, all following the same specifications, it is easier for maintainers to bump Go or other image dependencies in a single place. On top of that, there were an issue building `ppc64le` images because of a semantic error on the if condition that checks the arch used. Signed-off-by: Ferran Vidal <ferran.vidal.p@gmail.com>
|
Hey @aaron-prindle, while working on #2540 I realized that all Dockerfiles can be merged into one and use a multistage build approach. In that way all Dockerfile changes are distributed in the same way, caches are reused more efficiently, and some other benefits. Also, my last MR has an invalid if condition that breaks the build for ppc64le. |
aaron-prindle
approved these changes
Jun 5, 2023
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
…gleContainerTools#2547) As all Kaniko variants should be upgraded at once, all following the same specifications, it is easier for maintainers to bump Go or other image dependencies in a single place. On top of that, there were an issue building `ppc64le` images because of a semantic error on the if condition that checks the arch used. Signed-off-by: Ferran Vidal <ferran.vidal.p@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As all Kaniko variants should be upgraded at once, all following the same specifications, it is easier for maintainers to bump Go or other image dependencies in a single place.
On top of that, there were an issue building
ppc64leimages because of a semantic error on the if condition that checks the arch used.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes