Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valdiateFlags typo fixed #2554

Conversation

zigelboim-misha
Copy link
Contributor

Fixes a typo in:

Method called valdiateFlags was renamed to validateFlags.

Description

Fixes a typo in:

Method called valdiateFlags was renamed to validateFlags.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Method name typo:
- method `valdiateFlags` was renamed to `validateFlags`

@google-cla
Copy link

google-cla bot commented Jun 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aaron-prindle
Copy link
Collaborator

Thanks for the PR here @zigelboim-misha! If you can sign the Google CLA noted above we should be able to get this fix in 🎊

@zigelboim-misha
Copy link
Contributor Author

zigelboim-misha commented Jun 17, 2023

@aaron-prindle Sorry it took me some time, I signed it when opened the PR but now after I read your comment, I saw that the signing date was missing.
I hope to contribute more than a typo in the future as I’m a kaniko customer for a long time.
Again sorry for the trouble 🙏🏼

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @zigelboim-misha!

@aaron-prindle aaron-prindle merged commit 4b0bfd2 into GoogleContainerTools:main Jun 19, 2023
kylecarbs pushed a commit to coder/kaniko that referenced this pull request Jul 12, 2023
@zigelboim-misha zigelboim-misha deleted the fix/valdiateFlags-typo branch January 1, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants