Fix warmer memory leak. #2763
Fix warmer memory leak. #2763
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Is there à problem with the PR ? Why is it stuck for more than 1 month now ? |
There was a problem hiding this comment.
Sorry for the delay here @mxbossard, this PR is looking good. Just commented that a large commented code block should be removed and then I believe we can merge this.
…Add a script to test warmer in boxed memory conditions. Fixes: #2754
|
Hi, Do you plan to merge this soon ? |
| # limitations under the License. | ||
|
|
||
| set -e | ||
|
|
There was a problem hiding this comment.
Can you add a comment to this script explaining the purpose (eg: test warmer in boxed memory conditions) and an example of how to use it?
There was a problem hiding this comment.
I Added a documentation. I also fixed the swallowed error.
scripts/boxed_warm_in_docker.sh
Outdated
|
|
||
| set -e | ||
|
|
||
| #--entrypoint=/kaniko/warmer \ |
There was a problem hiding this comment.
nit: remove this comment
|
Is it ok for you ? |
|
Merged now, thanks for the fix here and your patience in getting it merged @mxbossard! |
|
Thank you for your work. |
Fixes: #2754
Description
Write down images directly into a temp file.
Then move files into final destination.
Add a script to test warmer in boxed memory conditions.
Submitter Checklist
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.