Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the build loop. #385

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

dlorenc
Copy link
Collaborator

@dlorenc dlorenc commented Oct 8, 2018

This change refactors the build loop a bit to make cache optimization easier in the future. Some notable changes:

  • The special casing around volume snapshots is removed. Every volume is added to the snapshotFiles list for every command that will snapshot anyway.
  • Snapshot saving was extracted to a sub-function

@dlorenc
Copy link
Collaborator Author

dlorenc commented Oct 8, 2018

cc @priyawadhwa

@dlorenc dlorenc force-pushed the refactorbuild branch 4 times, most recently from 744b0f4 to c725529 Compare October 8, 2018 21:23
This change refactors the build loop a bit to make cache optimization easier in the future. Some notable changes:

The special casing around volume snapshots is removed. Every volume is added to the snapshotFiles list for every command that will snapshot anyway.
Snapshot saving was extracted to a sub-function
The decision on whether or not to snapshot was extracted
@dlorenc
Copy link
Collaborator Author

dlorenc commented Oct 9, 2018

OK, tests finally passing!

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@dlorenc dlorenc merged commit 9a0e29c into GoogleContainerTools:master Oct 9, 2018
@dlorenc dlorenc deleted the refactorbuild branch October 9, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants