Separate Insecure Pull Options #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaniwaki
changed the title
dtaniwaki
force-pushed
the
insecure-pull
branch
from
33291ed
to
e24d644
Compare
dtaniwaki
changed the title
|
I'll kick off the integrations tests once the gofmt errors are fixed. |
dtaniwaki
force-pushed
the
insecure-pull
branch
from
e24d644
to
e04a922
Compare
|
/ok-to-test |
priyawadhwa
reviewed
Oct 25, 2018
|
Updated! Please check it again. |
priyawadhwa
approved these changes
Oct 26, 2018
|
Do you have any plan to release a new version including this fix? |
|
Hey @dtaniwaki we just released v0.6.0! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #401 (comment), it's possible to have either a source or destination registry is insecure. To get fine tuning of the security, we should separate the option.