-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support specifying branch for cloning #703
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 - could you push a no-op commit to get the checks completed - they're blocking on "kokoro Expected — Waiting for status to be reported " |
@caarlos0 - and, sorry to bother you again - do you think it's possible to get the checksum argument into the URL? I'd be willing to try implementing if you/they were interested (erlang dev here - but I'll try). I've been trying to get some feedback on https://groups.google.com/forum/#!topic/kaniko-users/G4TieNB8YaM |
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
AFAIK no, only branches and tags :/ Would need to do a full clone and then |
yeah seems like it refuses to run for some reason |
cc/ @priyawadhwa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @priyawadhwa ! |
thanks! |
this allows to specify a reference to clone in the same way npm allows: appending
#reference
to the URL, eg:git://github.com/GoogleContainerTools#refs/tags/v0.10.0
I'm not sure this is a good approach, but was the one I could think of without needing to change much.