Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix creating abs path for urls #804

Merged
merged 3 commits into from
Oct 4, 2019
Merged

fix creating abs path for urls #804

merged 3 commits into from
Oct 4, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Oct 4, 2019 •
edited
Loading

Fixes #803

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • [n/a] Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Fix regression introduced by #736. Dont resolve urls paths to absolute paths in command line arguments

@tejal29 tejal29 mentioned this pull request Oct 4, 2019
Closed
@tejal29 tejal29 merged commit 743a967 into GoogleContainerTools:master Oct 4, 2019
@tejal29 tejal29 deleted the fix_803 branch April 26, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccasland donmccasland donmccasland approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerfile path can no longer be an HTTP(S) address
2 participants
@tejal29 @donmccasland