Add unit tests for compositecache and stagebuilder #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add mock types for testing * enhance error messaging * add tests
cvgw
force-pushed
the
u/cvgw/compositecache-and-stagebuilder-unit-tests
branch
from
9473b46
to
33f3191
Compare
cvgw
force-pushed
the
u/cvgw/compositecache-and-stagebuilder-unit-tests
branch
from
fdf447e
to
6d0c8da
Compare
|
Found a bug that is breaking multi-stage caching https://github.com/GoogleContainerTools/kaniko/pull/890/files#diff-2f088cb5c32c8e57a7f5f1d34aed16ceR755 We should fix this in a follow up PR Issue #899 |
tejal29
reviewed
Dec 9, 2019
| } | ||
| } | ||
|
|
||
| func Test_CompositeCache_AddPath_dir(t *testing.T) { |
tejal29
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for compositecache and stagebuilder
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes