Issue 1178 helm secrets integration #1617

RoryShively · 2019-02-07T00:00:39Z

addresses issue 1178
#1178

googlebot · 2019-02-07T00:00:53Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

codecov-io · 2019-02-07T00:15:10Z

Codecov Report

Merging #1617 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
- Coverage   46.91%   46.89%   -0.02%     
==========================================
  Files         126      126              
  Lines        6167     6169       +2     
==========================================
  Hits         2893     2893              
- Misses       2976     2977       +1     
- Partials      298      299       +1

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm.go	`64.72% <66.66%> (-0.51%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a829c4...06c73d8. Read the comment docs.

nkubala

@RoryShively thanks for the contribution, looks pretty good just a small comment

nkubala · 2019-02-07T18:33:02Z

pkg/skaffold/deploy/helm.go

+		useSecrets = true
+	}
+
+	helmErr := h.helm(ctx, out, useSecrets, args...)


why not just pass r.UseHelmSecrets here?

Yes thats an obvious improvement. Will fix

nkubala · 2019-02-07T19:26:38Z

also, please sign the CLA :)

googlebot · 2019-02-07T22:24:05Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

RoryShively · 2019-02-07T22:25:46Z

also, please sign the CLA :)

I signed it!

googlebot · 2019-02-07T22:49:19Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

RoryShively · 2019-02-07T23:05:26Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Can somebody explain what this means and how I can address it?

rorymaidbot · 2019-02-07T23:10:56Z

I am ok with my commits being contributed to this project

nkubala · 2019-02-14T18:05:11Z

@RoryShively sorry, looks like you need a rebase here :( once that's done and Kokoro passes we can get this merged

RoryShively · 2019-02-21T19:22:36Z

@nkubala I rebased but I don't know what Kokoro is. How does it work? Whats the process to update it's status

RoryShively · 2019-02-26T17:43:00Z

@nkubala @balopat I don't know how to fix this cla issue. I accidentally used another account to push my commits but have signed the cla for both of my accounts. Does that need to be manually overridden?

googlebot · 2019-02-28T16:42:43Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2019-03-04T17:17:26Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

…ecified in config

googlebot · 2019-03-04T17:32:57Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

nkubala

@RoryShively sorry the super long delay here, this got a little buried after the CLA issue...that's my fault :( thanks for your contribution!

RoryShively requested review from balopat, dgageot, nkubala, priyawadhwa and r2d4 as code owners February 7, 2019 00:00

googlebot added the cla: no label Feb 7, 2019

RoryShively mentioned this pull request Feb 7, 2019

[Proposal] Add useHelmSecrets option to helm config #1178

Closed

nkubala reviewed Feb 7, 2019

View reviewed changes

balopat added needs-rebase !! config-change !! labels Feb 12, 2019

jeff-french mentioned this pull request Feb 13, 2019

Compatibility with skaffold zendesk/helm-secrets#67

Open

RoryShively force-pushed the issue-1178-helm-secrets-integration branch 3 times, most recently from afa08cc to ce1485c Compare February 21, 2019 16:52

balopat added the kokoro:run runs the kokoro jobs on a PR label Feb 25, 2019

kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 25, 2019

RoryShively force-pushed the issue-1178-helm-secrets-integration branch from ce1485c to 3e8c9a7 Compare February 28, 2019 16:42

googlebot removed the cla: no label Feb 28, 2019

googlebot added the cla: yes label Feb 28, 2019

RoryShively force-pushed the issue-1178-helm-secrets-integration branch from 3e8c9a7 to 06c73d8 Compare March 4, 2019 17:17

googlebot added cla: no and removed cla: yes labels Mar 4, 2019

created useHelmSecrets functionality to use helm secrets plugin if sp…

a892303

…ecified in config

RoryShively force-pushed the issue-1178-helm-secrets-integration branch from 06c73d8 to a892303 Compare March 4, 2019 17:32

googlebot added cla: yes and removed cla: no labels Mar 4, 2019

balopat added the kokoro:run runs the kokoro jobs on a PR label Mar 7, 2019

kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Mar 7, 2019

nkubala approved these changes Mar 11, 2019

View reviewed changes

nkubala merged commit b76ff3c into GoogleContainerTools:master Mar 11, 2019

tvvignesh mentioned this pull request May 20, 2020

Usage with helm-secrets vmware-tanzu/kubeapps#1098

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 1178 helm secrets integration #1617

Issue 1178 helm secrets integration #1617

RoryShively commented Feb 7, 2019

googlebot commented Feb 7, 2019

codecov-io commented Feb 7, 2019 •

edited

Loading

nkubala left a comment

nkubala Feb 7, 2019

RoryShively Feb 7, 2019

nkubala commented Feb 7, 2019

googlebot commented Feb 7, 2019

RoryShively commented Feb 7, 2019

googlebot commented Feb 7, 2019

RoryShively commented Feb 7, 2019

rorymaidbot commented Feb 7, 2019

nkubala commented Feb 14, 2019

RoryShively commented Feb 21, 2019

RoryShively commented Feb 26, 2019

googlebot commented Feb 28, 2019

googlebot commented Mar 4, 2019

googlebot commented Mar 4, 2019

nkubala left a comment

Issue 1178 helm secrets integration #1617

Issue 1178 helm secrets integration #1617

Conversation

RoryShively commented Feb 7, 2019

googlebot commented Feb 7, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

codecov-io commented Feb 7, 2019 • edited Loading

Codecov Report

nkubala left a comment

Choose a reason for hiding this comment

nkubala Feb 7, 2019

Choose a reason for hiding this comment

RoryShively Feb 7, 2019

Choose a reason for hiding this comment

nkubala commented Feb 7, 2019

googlebot commented Feb 7, 2019

RoryShively commented Feb 7, 2019

googlebot commented Feb 7, 2019

RoryShively commented Feb 7, 2019

rorymaidbot commented Feb 7, 2019

nkubala commented Feb 14, 2019

RoryShively commented Feb 21, 2019

RoryShively commented Feb 26, 2019

googlebot commented Feb 28, 2019

googlebot commented Mar 4, 2019

googlebot commented Mar 4, 2019

nkubala left a comment

Choose a reason for hiding this comment

codecov-io commented Feb 7, 2019 •

edited

Loading