Upgrade actions/{upload,download}-artifact

[YaSuenag]

Pull Request

Issue Number: #564

Summary

Upgrade actions/upload-artifact and actions/download-artifact in GHA workflow.

See GitHub Blog for details: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Changes

• .github/workflows/1-pr.yaml
• .github/workflows/dev_carbon-aware-api.yml
• .github/workflows/2.a-deploy.yaml.ignore

All of lines in 2.a-deploy.yaml.ignore are commented out, but I upgraded because this workflow might be enabled again in future.

One of actions/download-artifact in 1-pr.yaml uses v3 (non-deprecated version), but I upgraded because I think it is better to use same version entire workflows.

Checklist

• Local Tests Passing?
• CICD and Pipeline Tests Passing?
• Added any new Tests?
• Documentation Updates Made?
• Are there any API Changes? If yes, please describe below.
• This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

No

This PR Closes #564

[YaSuenag]

CC: @danuw

[danuw]

@YaSuenag sorry missed that. I did not update the workflow that is disabled but I guess we can close this and use the other one I fixed in the branch directly. Did not get a chance to apply the change until now but looks all good now
Thank you for that btw

[YaSuenag]

Changes for .github/workflows/1-pr.yaml does not seems to happen in #562 - I think we will see same error when other PR is filed.

@danuw
Should I revise this PR for 1-pr.yaml?