Refactor networking module

[GregHib]

• Reorganise network packaging
• Combine inventory data with inventories Improve inventory storage disconnect #497
• Remove login and logout from Player class closes Create Logout Class #438
• Move encryption library into networking module
• Remove old/unused classes (ConnectionGatekeeper, ClientManager, LoginManager, NetworkQueue)
• Add password hash to player info loaded on startup
• Encrypt password earlier in login stages
• Make PlayerAccountLoader reusable for bots
• Stop server on startup or engine exceptions
• Remove indexing from networking code
• Remove index allocator
• Add more networking tests closes Add more tests around GameServer #477

[codecov]

Codecov Report

Attention: Patch coverage is 76.15176% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 31.36%. Comparing base (0395799) to head (abaa846).

Additional details and impacted files

Files	Coverage Δ
.../kotlin/world/gregs/voidps/cache/secure/Huffman.kt	73.63% <100.00%> (ø)
...rld/gregs/voidps/engine/client/EncodeExtensions.kt	0.00% <ø> (ø)
...ps/engine/client/instruction/InstructionHandler.kt	0.00% <ø> (ø)
...s/engine/client/instruction/InstructionHandlers.kt	0.00% <ø> (ø)
...ne/client/instruction/handle/ChatPrivateHandler.kt	0.00% <ø> (ø)
...ine/client/instruction/handle/ChatPublicHandler.kt	0.00% <ø> (ø)
...client/instruction/handle/ChatTypeChangeHandler.kt	0.00% <ø> (ø)
...e/client/instruction/handle/ClanChatJoinHandler.kt	0.00% <ø> (ø)
...e/client/instruction/handle/ClanChatKickHandler.kt	0.00% <ø> (ø)
...e/client/instruction/handle/ClanChatRankHandler.kt	0.00% <ø> (ø)
... and 204 more

... and 388 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #501      +/-   ##
============================================
+ Coverage     27.20%   31.36%   +4.16%     
- Complexity     4028     4342     +314     
============================================
  Files          1225     1223       -2     
  Lines         39064    39109      +45     
  Branches       8244     8257      +13     
============================================
+ Hits          10626    12268    +1642     
+ Misses        25752    24057    -1695     
- Partials       2686     2784      +98     

Components	Coverage Δ
Content	22.34% <30.43%> (-0.13%)	⬇️
Engine	41.42% <71.06%> (+2.35%)	⬆️
Network	71.14% <96.36%> (+58.25%)	⬆️

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions