Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stackable items and add alternative door sounds #516

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Make stackable items and add alternative door sounds #516

merged 7 commits into from
Apr 11, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Apr 11, 2024

Closes #502, #511

Copy link

github-actions bot commented Apr 11, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 17.39130% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 31.55%. Comparing base (886b11f) to head (a292ffe).

Additional details and impacted files
Files Coverage Δ
...ld/gregs/voidps/engine/data/sql/DatabaseStorage.kt 98.52% <100.00%> (ø)
...lin/world/gregs/voidps/engine/queue/ActionQueue.kt 58.33% <0.00%> (-0.71%) ⬇️
...voidps/world/interact/entity/npc/combat/Attack.kts 22.72% <0.00%> (ø)
.../kotlin/world/gregs/voidps/engine/EngineModules.kt 0.00% <0.00%> (ø)
.../gregs/voidps/world/activity/skill/ItemOnItems.kts 53.39% <50.00%> (+0.39%) ⬆️
.../voidps/engine/data/config/ItemOnItemDefinition.kt 0.00% <0.00%> (ø)
...regs/voidps/world/interact/entity/obj/door/Door.kt 23.18% <10.00%> (-1.43%) ⬇️

... and 5 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #516      +/-   ##
============================================
- Coverage     31.56%   31.55%   -0.02%     
  Complexity     4377     4377              
============================================
  Files          1226     1226              
  Lines         39262    39272      +10     
  Branches       8286     8288       +2     
============================================
- Hits          12393    12391       -2     
- Misses        24072    24073       +1     
- Partials       2797     2808      +11     
Components Coverage Δ
Content 22.31% <20.00%> (-0.02%) ⬇️
Engine 42.47% <12.50%> (-0.02%) ⬇️
Network 71.14% <ø> (-0.04%) ⬇️

@GregHib GregHib merged commit eb6aa4a into main Apr 11, 2024
5 checks passed
@GregHib GregHib deleted the misc branch April 11, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max value to item on item
1 participant