Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combination runes, dungeoneering boxes and staves #520

Merged
merged 21 commits into from
Apr 25, 2024
Merged

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Apr 22, 2024

  • Add spell rune checks based off of cache cs2
  • Rewrite spell rune methods to be Inventory Transaction based
  • Add spell support for combination runes, staves, charges and non-members worlds
  • Fix the order of items in item-on-item calls
  • Fix using essence on runecrafting altar
  • Fix transaction revert list not clearing
  • Add dungeoneering nature and law staff functionality
  • Add dungeoneering blast and surge box functionality
  • Add altar ruin support for omni staff
  • Add combination runecrafting closes Add combination runes #399

Copy link

github-actions bot commented Apr 22, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@GregHib GregHib changed the title Add combination runes and dungeoneering boxes and staves Add combination runes, dungeoneering boxes and staves Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 65.43689% with 178 lines in your changes are missing coverage. Please review.

Project coverage is 32.33%. Comparing base (81df0ab) to head (b1d7c84).

Additional details and impacted files
Files Coverage Δ
...s/cache/definition/decoder/InterfaceDecoderFull.kt 41.96% <100.00%> (ø)
...oidps/cache/definition/encoder/InterfaceEncoder.kt 45.61% <100.00%> (ø)
...d/gregs/voidps/engine/data/definition/data/Rune.kt 35.71% <100.00%> (+4.94%) ⬆️
...d/gregs/voidps/engine/inv/transact/StateManager.kt 100.00% <100.00%> (ø)
...dps/engine/data/definition/InterfaceDefinitions.kt 2.94% <0.00%> (-0.03%) ⬇️
...otlin/world/gregs/voidps/engine/inv/Inventories.kt 33.33% <0.00%> (ø)
.../world/gregs/voidps/bot/skill/combat/CombatBot.kts 17.64% <0.00%> (ø)
...world/activity/transport/teleport/HomeTeleport.kts 3.70% <0.00%> (ø)
...ps/world/activity/transport/teleport/Teleports.kts 62.50% <0.00%> (ø)
...orld/interact/entity/player/combat/magic/Magic.kts 43.47% <0.00%> (+19.56%) ⬆️
... and 25 more

... and 12 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #520      +/-   ##
============================================
+ Coverage     31.69%   32.33%   +0.64%     
- Complexity     4417     4523     +106     
============================================
  Files          1231     1234       +3     
  Lines         39382    39754     +372     
  Branches       8318     8435     +117     
============================================
+ Hits          12481    12854     +373     
+ Misses        24083    24014      -69     
- Partials       2818     2886      +68     
Components Coverage Δ
Content 23.58% <69.19%> (+1.40%) ⬆️
Engine 43.18% <24.00%> (-0.07%) ⬇️
Network 71.14% <ø> (ø)

@GregHib GregHib marked this pull request as ready for review April 25, 2024 17:41
@GregHib GregHib merged commit ec11ec2 into main Apr 25, 2024
5 checks passed
@GregHib GregHib deleted the combination-runes branch April 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add combination runes
1 participant