Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runecrafting abyss #530

Merged
merged 30 commits into from
May 3, 2024
Merged

Add runecrafting abyss #530

merged 30 commits into from
May 3, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented May 2, 2024

Runecrafting:

  • Add mage of zamorak teleport
  • Add abyss monsters
  • Add abyss obstacles
  • Add abyss rifts
  • Add chaos altar maze

Misc:

  • Add better polygon area check
  • Fix multi-combat areas
  • Improved attack, hit and death animation id resolving
  • Add checking for owned and not-owned (lacking) items in drop tables closes Advanced drop tables #378
  • Fix drop simulating
  • Fix pouch drops
  • Add dropping and picking up items with charges
  • Add message log for testing

Copy link

github-actions bot commented May 2, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 57.34266% with 244 lines in your changes are missing coverage. Please review.

Project coverage is 33.39%. Comparing base (4a9b12d) to head (3d44c13).

Additional details and impacted files
Files Coverage Δ
...regs/voidps/world/activity/skill/mining/Mining.kts 38.77% <100.00%> (-6.68%) ⬇️
...regs/voidps/world/activity/skill/mining/Pickaxe.kt 100.00% <100.00%> (ø)
...voidps/world/activity/skill/woodcutting/Hatchet.kt 100.00% <100.00%> (ø)
.../voidps/world/interact/entity/combat/Wilderness.kt 70.58% <100.00%> (ø)
...voidps/world/interact/entity/item/ItemDropping.kts 68.75% <100.00%> (+12.50%) ⬆️
.../gregs/voidps/world/interact/entity/obj/Stairs.kts 41.66% <ø> (+14.74%) ⬆️
...gregs/voidps/world/interact/entity/obj/Teleport.kt 81.25% <100.00%> (+0.60%) ⬆️
...ps/engine/entity/character/player/chat/Messages.kt 0.00% <0.00%> (ø)
...gregs/voidps/engine/entity/item/floor/FloorItem.kt 95.23% <66.66%> (+5.23%) ⬆️
...idps/engine/entity/item/floor/FloorItemTracking.kt 94.11% <85.71%> (ø)
... and 24 more

... and 14 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #530      +/-   ##
============================================
+ Coverage     33.05%   33.39%   +0.34%     
- Complexity     4589     4611      +22     
============================================
  Files          1257     1262       +5     
  Lines         40709    41079     +370     
  Branches       8665     8718      +53     
============================================
+ Hits          13457    13719     +262     
- Misses        24247    24347     +100     
- Partials       3005     3013       +8     
Components Coverage Δ
Content 25.50% <58.97%> (+0.74%) ⬆️
Engine 44.34% <45.74%> (+0.09%) ⬆️
Network 71.24% <ø> (ø)

@GregHib GregHib marked this pull request as ready for review May 3, 2024 17:12
@GregHib GregHib merged commit f4c7c6f into main May 3, 2024
5 checks passed
@GregHib GregHib deleted the abyss branch May 3, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced drop tables
1 participant