Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename expressions to official names #531

Merged
merged 9 commits into from
May 3, 2024
Merged

Rename expressions to official names #531

merged 9 commits into from
May 3, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented May 3, 2024

Official names:

  • Happy
  • Angry
  • Neutral
  • Shifty
  • Quiz

Other renames:

  • Frustrated
  • Pleased

Misc:

  • Fix crafting leather requirements

Copy link

github-actions bot commented May 3, 2024

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1359 lines in your changes are missing coverage. Please review.

Project coverage is 33.40%. Comparing base (f4c7c6f) to head (9995e1b).

Additional details and impacted files
Files Coverage Δ
.../gregs/voidps/world/interact/entity/npc/Banker.kts 11.11% <0.00%> (ø)
...in/kotlin/world/gregs/voidps/world/map/MilkCow.kts 5.55% <0.00%> (ø)
...egs/voidps/world/map/varrock/palace/SurokMagis.kts 25.00% <0.00%> (ø)
...n/world/gregs/voidps/world/map/al_kharid/Ellis.kts 4.05% <0.00%> (ø)
...s/voidps/world/map/al_kharid/duel_arena/Nurses.kts 14.28% <0.00%> (ø)
...lin/world/gregs/voidps/world/map/draynor/Leela.kts 25.00% <0.00%> (ø)
.../voidps/world/map/neitiznot/ThakkradSigmundson.kts 6.25% <0.00%> (ø)
...s/world/activity/dnd/shootingstar/ShootingStar.kts 7.85% <0.00%> (ø)
...orld/gregs/voidps/world/map/al_kharid/Tollgate.kts 12.72% <0.00%> (ø)
...rld/gregs/voidps/world/map/falador/Hairdresser.kts 6.25% <0.00%> (ø)
... and 61 more

... and 4 files with indirect coverage changes

@@            Coverage Diff            @@
##               main     #531   +/-   ##
=========================================
  Coverage     33.39%   33.40%           
+ Complexity     4611     4610    -1     
=========================================
  Files          1262     1262           
  Lines         41079    41079           
  Branches       8718     8718           
=========================================
+ Hits          13719    13723    +4     
+ Misses        24348    24347    -1     
+ Partials       3012     3009    -3     
Components Coverage Δ
Content 25.51% <0.00%> (+0.01%) ⬆️
Engine 44.34% <ø> (ø)
Network 71.24% <ø> (ø)

@GregHib GregHib merged commit b040377 into main May 3, 2024
5 checks passed
@GregHib GregHib deleted the expressions branch May 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant