Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ourania zmi altar #537

Merged
merged 29 commits into from
May 18, 2024
Merged

Add ourania zmi altar #537

merged 29 commits into from
May 18, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented May 16, 2024

  • Add ourania cave
  • Add ourania banker
  • Add rune banking interface
  • Add aggressive monsters
  • Add cave crack
  • Add ourania alter runecrafting
  • Add rune crafters
  • Add PatrolDefinitions and patrols.yml

Misc:

  • Add rune pouch degrade message
  • Fix sapphire bullseye lantern
  • Remove hunt mode checkTolerance in favour of checkAfk
  • Fix npc multi-combat areas
  • Fix attackers not being removed from attackers list after combat
  • Add conditions to player auto retaliation
  • Fix patrolling from clearing itself
  • Fix lootshare status not shown on login

Copy link

github-actions bot commented May 16, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 25.71429% with 286 lines in your changes are missing coverage. Please review.

Project coverage is 33.44%. Comparing base (20c0c90) to head (f8f3f89).

Additional details and impacted files
Files Coverage Δ
...d/gregs/voidps/engine/data/definition/data/Rune.kt 37.93% <100.00%> (+4.59%) ⬆️
.../gregs/voidps/engine/entity/character/mode/Mode.kt 100.00% <100.00%> (ø)
.../gregs/voidps/engine/entity/character/mode/Rest.kt 0.00% <ø> (ø)
...gs/voidps/engine/entity/character/player/Player.kt 72.09% <100.00%> (ø)
...ngine/entity/character/player/skill/level/Level.kt 5.00% <ø> (ø)
...ps/engine/data/definition/ItemOnItemDefinitions.kt 0.00% <0.00%> (ø)
.../gregs/voidps/engine/entity/character/mode/Face.kt 0.00% <0.00%> (ø)
...regs/voidps/engine/entity/character/mode/Patrol.kt 0.00% <0.00%> (ø)
...ps/engine/entity/character/mode/move/PathFinder.kt 59.18% <0.00%> (ø)
...ld/gregs/voidps/engine/entity/character/npc/NPC.kt 36.66% <0.00%> (ø)
... and 31 more

... and 5 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #537      +/-   ##
============================================
- Coverage     33.49%   33.44%   -0.05%     
- Complexity     4628     4651      +23     
============================================
  Files          1267     1277      +10     
  Lines         41477    41786     +309     
  Branches       8796     8864      +68     
============================================
+ Hits          13893    13977      +84     
- Misses        24531    24731     +200     
- Partials       3053     3078      +25     
Components Coverage Δ
Content 25.92% <30.61%> (+0.06%) ⬆️
Engine 44.00% <6.41%> (-0.24%) ⬇️
Network 71.29% <ø> (ø)

@GregHib GregHib marked this pull request as ready for review May 18, 2024 18:10
@GregHib GregHib merged commit bacbfe9 into main May 18, 2024
5 checks passed
@GregHib GregHib deleted the ourania-zmi-altar branch May 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant