Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove create_if_not_exists from region CreateRequest #106

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Sep 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR removes create_if_not_exists from CreateRequest

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag changed the title feat!: remove create_if_not_exists from region CreateRequest feat: remove create_if_not_exists from region CreateRequest Sep 20, 2023
@evenyag evenyag marked this pull request as ready for review September 20, 2023 06:38
@evenyag evenyag closed this Sep 20, 2023
@evenyag evenyag reopened this Sep 20, 2023
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 115c108 into main Sep 20, 2023
16 of 17 checks passed
@evenyag evenyag deleted the feat/remove-create-if-not-exists branch September 20, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants