Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IF EXISTS for DROP #123

Merged
merged 3 commits into from
Nov 24, 2023
Merged

feat: add IF EXISTS for DROP #123

merged 3 commits into from
Nov 24, 2023

Conversation

zuston
Copy link
Contributor

@zuston zuston commented Nov 23, 2023

For GreptimeTeam/greptimedb#2794

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Summarize your change

Add the drop_if_exists to match the mysql statement for drop

  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zuston
Copy link
Contributor Author

zuston commented Nov 23, 2023

PTAL @sunng87 @waynexia

@waynexia
Copy link
Member

Please run make to generate language-specific code

@zuston
Copy link
Contributor Author

zuston commented Nov 23, 2023

Please run make to generate language-specific code

Oh yes. I thought the generated code will be did by the bot.

Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia enabled auto-merge (squash) November 24, 2023 02:37
Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you make a rebase to solve conflicts? Thank you!

@zuston
Copy link
Contributor Author

zuston commented Nov 24, 2023

LGTM.

Can you make a rebase to solve conflicts? Thank you!

Sorry, it has some conflict and can't rebase. BTW, I don't have complete compile chain like golang and cmake in my mac.

@waynexia
Copy link
Member

LGTM.
Can you make a rebase to solve conflicts? Thank you!

Sorry, it has some conflict and can't rebase. BTW, I don't have complete compile chain like golang and cmake in my mac.

Our makefile utilizes docker to generate code, only a docker env is required

@zuston
Copy link
Contributor Author

zuston commented Nov 24, 2023

LGTM.
Can you make a rebase to solve conflicts? Thank you!

Sorry, it has some conflict and can't rebase. BTW, I don't have complete compile chain like golang and cmake in my mac.

Our makefile utilizes docker to generate code, only a docker env is required

Yes, but my personal mac's docker client is connected to my company's internal docker server due to the limited disk space. And I found the golang dependency is still needed.

image

@waynexia waynexia merged commit 2aaee38 into GreptimeTeam:main Nov 24, 2023
6 checks passed
@waynexia
Copy link
Member

LGTM.
Can you make a rebase to solve conflicts? Thank you!

Sorry, it has some conflict and can't rebase. BTW, I don't have complete compile chain like golang and cmake in my mac.

Our makefile utilizes docker to generate code, only a docker env is required

Yes, but my personal mac's docker client is connected to my company's internal docker server due to the limited disk space. And I found the golang dependency is still needed.

image

Whoops...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants